Open obucklin opened 8 months ago
can you add a Rhino+GH file to reproduce?
# self.main_beam.add_blank_extension(start_main, end_main, self.key)
# self.cross_beam.add_blank_extension(start_cross, end_cross, self.key)
self.main_beam.add_blank_extension(1, 1, self.key)
self.cross_beam.add_blank_extension(1, 1, self.key)
i had to do this to get it to trim, even though the beams were extended enough to intersect iwth the planes. I tried flipping the planes which helped in some cases.
can you add a Rhino+GH file to reproduce?
in my new PR, examples\Grasshopper\CT_NEW_UI_Example.3dm, examples\Grasshopper\CT_NEW_UI_Example.gh
in src\compas_timber\connections\l_halflap.py
lines 220-223 or src\compas_timber\connections\l_butt.py
lines 114-115
old lines are commented out. My hack only works if using meters for scale.
here's a sample file. Branch is on main.
The cross beam doesn't trim on the L-Butt joint. I tried changing this in the L-Butt def
by adding
f_cross = CutFeature(self.cutting_plane_cross) self.cross_beam.add_features(f_cross) self.features.append(f_cross)
but I get error: `Runtime error (Exception): Trim operation ended with no result
Traceback: line 44, in result, "C:\Users\obucklin\AppData\Roaming\McNeel\Rhinoceros\7.0\scripts\compas_timber\consumers\geometry.py" line 356, in trim, "C:\Users\obucklin\AppData\Roaming\McNeel\Rhinoceros\7.0\scripts\compas_rhino\geometry\brep\brep.py" line 19, in apply_cut_feature, "C:\Users\obucklin\AppData\Roaming\McNeel\Rhinoceros\7.0\scripts\compas_timber\consumers\geometry.py" line 52, in _apply_features, "C:\Users\obucklin\AppData\Roaming\McNeel\Rhinoceros\7.0\scripts\compas_timber\consumers\geometry.py" line 59, in RunScript, ""
`