gramaziokohler / compas_timber

https://gramaziokohler.github.io/compas_timber/
MIT License
19 stars 26 forks source link

revise how crossbeam is cut in L-Butt joint #85

Closed funkchaser closed 1 year ago

funkchaser commented 1 year ago

Describe the bug Currently, in an L-Butt joint, the cross beam is not cut, but only extended. The extension is calculated so that - when cut - it results in a neat corner. But if not cut, and the angle between beams is acute, this extensions is larger than needed and looks bad.

Previously, it was cut with a side of the main beam and it worked as intended in two-beam corners. But then it was removed because it led to unwanted results if the beams were involved in multiple joints (e.g. corner of a cube). This was a quick-fix rather than a solution, and the problem was rather in how the user specified the joints and expected good results automagically.

image

To Reproduce

https://github.com/gramaziokohler/compas_timber/commit/6956f5f74244e1fe779124609f658a3620d8ef1f

Expected behavior one of the two:

image

funkchaser commented 1 year ago

resolved with #86