COMPAS XR streamlines extended reality workflows to ease the implementation of human-machine collaborative applications in architectural research and educational environments.
This Pull Request Contains 1 Major update as well as minor updates to dependent classes (RealtimeDatabase and Storage)
Major update is the introduction and functionality of the assemblies module and the AssemblyAssistant class... Includes the introduction of all functionalities related to uploading assemblies and timber assemblies to realtimedatabase and storage. Accessible in Rhino via From compas_xr.assemblies import AssemblyAssistant
Minor updates include changes in the upload_data_aschild() and upload_data_aschildren() class methods in the RealtimeDatabase class. These changes include removing input data sorting parameters and making function more generic to accept any data reguardless of its structure. Also, they should probably be renamed, but I am struggling to come up with a more descriptive name.
Question: This works well in the upload data because data is more flexible than the file in terms of input, but I am not sure how to create a similar strategy (without input parameters) for the upload_file_aschild() and upload_file_aschildren() methods
Additionally: Minor questions are left in the repo using #TODO: comments
What type of change is this?
[ ] Bug fix in a backwards-compatible manner.
[x] New feature in a backwards-compatible manner.
[ ] Breaking change: bug fix or new feature that involve incompatible API changes.
[ ] Other (e.g. doc update, configuration, etc)
Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.
[ ] I added a line to the CHANGELOG.md file in the Unreleased section under the most fitting heading (e.g. Added, Changed, Removed).
[ ] I ran all tests on my computer and it's all green (i.e. invoke test).
[ ] I ran lint on my computer and there are no errors (i.e. invoke lint).
[x] I added new functions/classes and made them available on a second-level import, e.g. compas.datastructures.Mesh.
[x] I have added tests that prove my fix is effective or that my feature works.
[ ] I have added necessary documentation (if appropriate)
This Pull Request Contains 1 Major update as well as minor updates to dependent classes (RealtimeDatabase and Storage)
assemblies
module and theAssemblyAssistant
class... Includes the introduction of all functionalities related to uploading assemblies and timber assemblies to realtimedatabase and storage. Accessible in Rhino viaFrom compas_xr.assemblies import AssemblyAssistant
upload_data_aschild()
andupload_data_aschildren()
class methods in the RealtimeDatabase class. These changes include removing input data sorting parameters and making function more generic to accept any data reguardless of its structure. Also, they should probably be renamed, but I am struggling to come up with a more descriptive name.Question: This works well in the upload data because data is more flexible than the file in terms of input, but I am not sure how to create a similar strategy (without input parameters) for the
upload_file_aschild()
andupload_file_aschildren()
methodsAdditionally: Minor questions are left in the repo using #TODO: comments
What type of change is this?
Checklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.CHANGELOG.md
file in theUnreleased
section under the most fitting heading (e.g.Added
,Changed
,Removed
).invoke test
).invoke lint
).compas.datastructures.Mesh
.