gramaziokohler / compas_xr

COMPAS XR streamlines extended reality workflows to ease the implementation of human-machine collaborative applications in architectural research and educational environments.
https://gramaziokohler.github.io/compas_xr/
MIT License
7 stars 0 forks source link

Assembly class #6

Closed jckenny59 closed 3 weeks ago

jckenny59 commented 8 months ago

This Pull Request Contains 1 Major update as well as minor updates to dependent classes (RealtimeDatabase and Storage)

  1. Major update is the introduction and functionality of the assemblies module and the AssemblyAssistant class... Includes the introduction of all functionalities related to uploading assemblies and timber assemblies to realtimedatabase and storage. Accessible in Rhino via From compas_xr.assemblies import AssemblyAssistant

image

  1. Minor updates include changes in the upload_data_aschild() and upload_data_aschildren() class methods in the RealtimeDatabase class. These changes include removing input data sorting parameters and making function more generic to accept any data reguardless of its structure. Also, they should probably be renamed, but I am struggling to come up with a more descriptive name.

image

Question: This works well in the upload data because data is more flexible than the file in terms of input, but I am not sure how to create a similar strategy (without input parameters) for the upload_file_aschild() and upload_file_aschildren() methods

Additionally: Minor questions are left in the repo using #TODO: comments

What type of change is this?

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

gonzalocasas commented 3 weeks ago

This PR has been replaced by others and the features are already merged into main.