gramaziokohler / ros_docker

Docker images for ROS master, bridge and nodes
MIT License
76 stars 18 forks source link

Set permissions explicitly for entrypoint #4

Closed tetov closed 4 years ago

tetov commented 4 years ago

Set the executable bit explicitly for /ros_catkin_entrypoint.sh. Why?

If the docker build context resides in a Windows file system, every file in the build context gets 'rwxr-xr-x set by default since Windows doesn't have an executable permission equivalent.

If the docker build context is in a Linux file system, it needs to be set as executable explicitly. Either by having the script file commited to git with the correct permission or by setting it in the Dockerfile. Setting it in the dockerfile seems to me to be the more transparent option.