Closed MisterOwlPT closed 1 year ago
Thanks! On a first glance, it looks ok, I'll check a bit more in detail and we merge. In the meantime, could you please add your name to the AUTHORS.rst
and also try merging main
to your branch, because that should fix the build issue? thanks!
Hi :) Suggested alterations were done.
Hi :)
I saw the open issue #95 and decided to fix the reported bug. As reported, an error occurs when you try to run the ROS action example from the documentation. The proposed changes solve the said bug.
What type of change is this?
Checklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.CHANGELOG.rst
file in theUnreleased
section under the most fitting heading (e.g.Added
,Changed
,Removed
).invoke test
). NOTE: One test is failing. However, I checked themain
branch and that same test also failed there so I don't think it's related to my changes.invoke check
).Some remarks
After some debugging, I think I've found the origin of the problem.
It seems that the action client was receiving the result all along! However, the client's
wait
function always raises the shown exception because no status message is being published with adequate SUCCEEDED and PREEMPTED status codes by the action server. Since these messages are not published, the client'sis_finished
property never returnsTrue
and therefore the client keeps on waiting for the result (even after having received it).After ensuring that proper status messages are published inside the server's
set_succeeded
andset_preempted
functions, the following now happens when running the documentation example:Checking published messages with
rostopic echo
the following message are now detected:No such message was shown before.
Please let me know what you think of these changes. If they seem okay to you, I can implement some unit tests later :)