gramaziokohler / roslibpy

Python ROS Bridge library
MIT License
273 stars 56 forks source link

Fix Python 2.7 syntax #106

Closed gonzalocasas closed 1 year ago

gonzalocasas commented 1 year ago

Pull Request https://github.com/gramaziokohler/roslibpy/pull/105 introduced syntax that is not compatible with Python 2.7 / IronPython.

What type of change is this?

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

gonzalocasas commented 1 year ago

/cc @DomenicP

DomenicP commented 1 year ago

Apologies for introducing this bug, didn't realize that TimeoutError was new in Python 3. It looks like this repo is already setup with GitHub Actions and a matrix for Python versions, maybe it would be helpful to add all of the Python versions for actively supported ROS distros or Python versions to that matrix? I'll look into opening a follow-up PR to add this

DomenicP commented 1 year ago

Opened #107 if anyone is interested in a follow-up discussion for testing compatibility with Python 2.7 (and other Python 3 versions).