search

gramaziokohler / roslibpy

Python ROS Bridge library
MIT License
273 stars 56 forks source link

Specify tls dependencies of Twisted package in setup.py #111

Closed tlpss closed 1 year ago

tlpss commented 1 year ago

when setting up the webserver for ROS galactic in a docker container, the following warning is shown while running the example code: :0: UserWarning: You do not have a working installation of the service_identity module: 'No module named 'service_identity''. Please install it from <https://pypi.python.org/pypi/service_identity> and make sure all of its dependencies are satisfied. Without the service_identity module, Twisted can perform only rudimentary TLS client hostname verification. Many valid certificate/hostname mappings may be rejected.

I believe this can be easily fixed by specifying twisted[tls] as dependency instead of twisted. This fixes the issue as the missing dependency is installed (cf here for the tls dependencies of twisted)

gonzalocasas commented 1 year ago

Thanks for the report, I added it on #112, we'll merge and release soon.

tlpss commented 1 year ago

great, thanks!

gonzalocasas commented 1 year ago

release in progress! it will land on pip in a couple of minutes, and conda in some hours