Closed iliabaranov closed 4 months ago
Gentle ping on this? :) Perhaps @gonzalocasas ?
Any chance this could get merged? :)
@iliabaranov thanks a lot for the contribution! I think it's not a good idea to add a breaking change for this, so, I took your PR and extended it a bit more. I kept your commits so that what you did is properly credited, but I will open a new PR in a bit with more stuff and a non-breaking change version of this.
As mentioned here: https://github.com/gramaziokohler/roslibpy/issues/109
Header message in ROS2 no longer supports the seq field. Hence I have removed it, and modified the tests to ensure the correct behavior is followed.
Followed the steps here: https://github.com/gramaziokohler/roslibpy/blob/f60cf8f3c385985e59bbb8967caf6ec5c8355c3d/CONTRIBUTING.rst
Unsure this is a breaking change? I suspect so, but really it makes the header message work properly now, where it failed before.
What type of change is this?
Checklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.CHANGELOG.rst
file in theUnreleased
section under the most fitting heading (e.g.Added
,Changed
,Removed
).invoke test
).invoke check
).