gramaziokohler / roslibpy

Python ROS Bridge library
MIT License
273 stars 56 forks source link

Add minimal support for ROS2 #123

Closed gonzalocasas closed 4 months ago

gonzalocasas commented 4 months ago

This PR builds up on https://github.com/gramaziokohler/roslibpy/pull/120 but makes it a non-breaking change instead. Added ROS2 to the CI tests also, although only testing one tiny part of ROS2 so far.

What type of change is this?

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

gonzalocasas commented 4 months ago

@iliabaranov I've moved your fix to a roslibpy.ros2.Header class and now everything seems to work on both ROS1 and ROS2. I will merge and cut a new release with this.

iliabaranov commented 4 months ago

Cheers, thanks! :D

gonzalocasas commented 4 months ago

I'll try to add actionlib support soon and fix the rest of the tests

gonzalocasas commented 4 months ago

Please let me know if you encounter any issues in the meantime