gramaziokohler / roslibpy

Python ROS Bridge library
MIT License
273 stars 56 forks source link

master to main/roscore #75

Closed beverlylytle closed 3 years ago

beverlylytle commented 3 years ago

Closes #74

What type of change is this?

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

beverlylytle commented 3 years ago

I am uncertain if -eventually- we should not just refer to ROS instead of roscore actually. It would fit the updated strings as well, and it might be even less confusing for users (potentially also correct for ROS2).

Ah, good point. Referring to ROS does make more sense for the docstrings and the logger info. Will change.

gonzalocasas commented 3 years ago

:shipit: 👍 🚀