gramaziokohler / roslibpy

Python ROS Bridge library
MIT License
273 stars 56 forks source link

close #92: add host/port params to the command line interface #93

Closed gonzalocasas closed 2 years ago

gonzalocasas commented 2 years ago

Address #92 , adding both host and port params to the CLI.

What type of change is this?

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

gonzalocasas commented 2 years ago

@jrjbertram does this sound about right to you? If one needs to pass it from env vars, it's easy to do so as well via the cli args.

jrjbertram commented 2 years ago

That would work, thank you!