search

grambank / grambank-analysed

3 stars 0 forks source link

Update plot_unusualness.R #51

Closed HedvigS closed 2 years ago

HedvigS commented 2 years ago

Hi @blasid . I went through part of your plot unusalness script and made some updates.

Is this in the right direction? Can you approve and merge if so please.

HedvigS commented 2 years ago

I think what might be happening is that you're operation on the object at the end of this script before the renaming, that's why this plot script says "prob_ker_20" etc instead of "Kernel 20" like the table in the file.

HedvigS commented 2 years ago

@blasid is it save to assume that the Language_ID column in gb in get_unusualness_bayesLCA.R is in the same order as the output of estimate_unusualness_LCA ?

i.e., can I go:

unusualness_df$Language_ID <-gb$Language_ID

HedvigS commented 2 years ago

I'll re-assess this PR's changes and conflicts once #53 is resolved. Please @blasid don't merge it in before that.

RustyGray commented 2 years ago

Hi, is this essential? Can’t you just give Damian the matrices he wants now and sort thins out later? I am concerned that we are running out of time to get this submitted before your wedding and ICHL. Can we discuss this tomorrow please? Thanks, Russell.

HedvigS commented 2 years ago

Hi, is this essential? Can’t you just give Damian the matrices he wants now and sort thins out later? I am concerned that we are running out of time to get this submitted before your wedding and ICHL. Can we discuss this tomorrow please? Thanks, Russell.

I guess I could bypass the regular way of doing things and send him some files over email.

This shouldn't take long to sort out though, we noticed it Friday and I think hopefully Johannes will agree with me in #53 to do a hard reset to the changes just after DInnage's latest committ.

But okay, I'll work on it outside of this framework and send him files over emails.

This PR is about something else. This is about plot changes that Damián wanted. He's the reviewer, I can't merge this in without his approval. We can't merge in before we resolve the conflicts, and we can't resolved the conflicts before we resolve #53 .

But, I can email him precision matrices that he needs for #54 , yes.