search

grambank / grambank-analysed

3 stars 0 forks source link

Revert "Merge branch 'main' of https://github.com/grambank/grambank-a… #56

Closed HedvigS closed 2 years ago

HedvigS commented 2 years ago

…nalysed"

This reverts commit d03281698534759f9ab2c552136848fc445e69cd, reversing changes made to c64f25cddcef95f937afff8bb25719cce79748d2.

HedvigS commented 2 years ago

I think this solves #53

@blasid please note that this reverts work of yours from last week. So if there is anything in here that you want in the main branch, please commit to a new branch and make a new PR for those changes.

SamPassmore commented 2 years ago

Hi Hedvig I added some changes to your branch to the dual model plot. I discuss them in #44 but i thought I would flag that this is where the changes are.

HedvigS commented 2 years ago

Hi Hedvig I added some changes to your branch to the dual model plot. I discuss them in #44 but i thought I would flag that this is where the changes are.

Understood.

I've made some changes that Russell suggested on that plot in another branchhttps://github.com/grambank/grambank-analysed/tree/asap-work-on-old-main-branch but we can work that out. I might revert or override some of your changes based on what RG and I talked about in person yesterday, but no worries. it'll work out :)

HedvigS commented 2 years ago

@SamPassmore to make things easier right now I'll go over the changes you made in the dual plot and if they're not contradicting what RG told me in person yesterday I'll take them and implement them in another branch and PR. They will not be lost!