grambank / pygrambank

Apache License 2.0
4 stars 1 forks source link

Clean up command-line #120

Open johenglisch opened 3 months ago

johenglisch commented 3 months ago

I'm in the mood of deleting code, so I thought it might be a good idea to get rid of some old pygrambank functionality that clutters up the command-line interface:

Contenders for the chopping block:

Never used those but might keep them around in case they become useful:

@xrotwang @hedvigs Is there anything in this list you want or need to be preserved for one reason or another?

xrotwang commented 3 months ago

Re download_issues: The issues discussing coding of certain features were supposed to be made public. Since they live in the private repository glottobank/Grambank, they needed to be pulled from there and put into the zenodo release. I'd assume this functionality is still needed.

xrotwang commented 3 months ago

The issues command is there to check whether the downloaded github issues can be parsed as expected. So should stay as well.

johenglisch commented 3 months ago

The issues discussing coding of certain features were supposed to be made public.

Was that ever done for Grambank v1.0?

xrotwang commented 3 months ago

Maybe not. The download has been run at some point, though, see the results in https://github.com/glottobank/Grambank/tree/master/archived_discussions

johenglisch commented 3 months ago

Okay, I just gave the command a try. So, it downloads all issues (old and new; including PRs apparently) and dumps them into a massive json file. I assume the json data is filtered and rendered somewhere else?

xrotwang commented 3 months ago

I guess before spending any amount of time on this, @HedvigS should chime in on whether/how any of the issue discussions should be preserved and made public at some point.