Open johenglisch opened 3 months ago
Re download_issues
: The issues discussing coding of certain features were supposed to be made public. Since they live in the private repository glottobank/Grambank
, they needed to be pulled from there and put into the zenodo release. I'd assume this functionality is still needed.
The issues
command is there to check whether the downloaded github issues can be parsed as expected. So should stay as well.
The issues discussing coding of certain features were supposed to be made public.
Was that ever done for Grambank v1.0?
Maybe not. The download has been run at some point, though, see the results in https://github.com/glottobank/Grambank/tree/master/archived_discussions
Okay, I just gave the command a try. So, it downloads all issues (old and new; including PRs apparently) and dumps them into a massive json file. I assume the json data is filtered and rendered somewhere else?
I guess before spending any amount of time on this, @HedvigS should chime in on whether/how any of the issue discussions should be preserved and made public at some point.
I'm in the mood of deleting code, so I thought it might be a good idea to get rid of some old pygrambank functionality that clutters up the command-line interface:
Contenders for the chopping block:
cleanmojibake
(replaced byrecode
)download_issues
(seems to download HTML from github issues – no idea why)enrichgb20
(no idea what that does)fixhg
(solved an old problem at some time?)issue1786
(solved an old problem at some time?)issue1797
(solved an old problem at some time?)issues
(no idea what that does, doesn't even look like a valid subcommant)merge_contrib
(no idea what that does)roundtrip
(just reads and writes a sheet – I assume to normalise quotes and line endings? If so, it's supercedes byremove_empty
)Never used those but might keep them around in case they become useful:
fix
: runs a lambda function on all cells of a sheetupdatefeatures
: adds new features to an existing sheet@xrotwang @hedvigs Is there anything in this list you want or need to be preserved for one reason or another?