search

grambank / pygrambank

Apache License 2.0
4 stars 1 forks source link

Refmatchchecks #2

Closed d97hah closed 5 years ago

d97hah commented 5 years ago

I did a few pushes directly to master but I realise this is the proper way to go about it

xrotwang commented 5 years ago

Indeed, PRs are the way to go - in particular if you only work and test on py2 :)

codecov-io commented 5 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@527663d). Click here to learn what that means. The diff coverage is 65.38%.

Impacted file tree graph

@@           Coverage Diff            @@
##             master      #2   +/-   ##
========================================
  Coverage          ?   96.4%           
========================================
  Files             ?       7           
  Lines             ?     639           
  Branches          ?       0           
========================================
  Hits              ?     616           
  Misses            ?      23           
  Partials          ?       0
Impacted Files Coverage Δ
src/pygrambank/cldf.py 98.31% <57.14%> (ø)
src/pygrambank/sheet.py 93.71% <66.66%> (ø)
src/pygrambank/srctok.py 92% <70%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 527663d...8c29530. Read the comment docs.

d97hah commented 5 years ago

But there's hope at the end of the tunnel, I've installed python 3.7 ... and there were some windows-specific changes :-)

Pada tanggal Kam, 25 Apr 2019 pukul 08.12 Robert Forkel < notifications@github.com> menulis:

Indeed, PRs are the way to go - in particular if you only work and test on py2 :)

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/glottobank/pygrambank/pull/2#issuecomment-486533055, or mute the thread https://github.com/notifications/unsubscribe-auth/AA2QHSGA3QVEX7D545P2OJ3PSFDTFANCNFSM4HIJKQYA .

xrotwang commented 5 years ago

I've heard about the "only upgrade after service pack 3 was released"-rule for windows. But skipping py 3.1-6 seems a bit excessive :)