search

grambank / pygrambank

Apache License 2.0
4 stars 1 forks source link

check selects wrong sheet? #6

Closed HedvigS closed 5 years ago

HedvigS commented 5 years ago

In the case of tumu1242 check has given true for "selected" for Martin's sheet, i.e. MH_tumu1242.tsv. Martin's sheet contains the fewest non missing values out of the three sheets for this language. It shouldn't be the one selected. Unless I've misunderstood something?

Didn't we have this problem before, and wasn't it fixed then? What's up?

HedvigS commented 5 years ago

See previous discussion here.

HedvigS commented 5 years ago

I've written R scripts that update the "to code" and "to revise" lists. When the pygrambank check command no longer selects for Martin's sheet and I'm able to run it on my machine, I'll make a PR request with those scripts and re-direct coders to the correct sheet for revision.

xrotwang commented 5 years ago

Fixed: https://github.com/glottobank/pygrambank/commit/3995df294774aad8b4b8aca9d07fe108afbd7eba

HedvigS commented 5 years ago

Great.

Is there somewhere I can access some bare documentation forpygrambank check? Just so that it is as easy as possible to run every-time.

xrotwang commented 5 years ago

It's just

grambank --repos PATH/TO/Grambank check
HedvigS commented 5 years ago

Great. Last time it was

grambank --repos ../Grambank --wiki_repos ../Grambank.wiki check ../../glottolog/glottolog

so I'm just double checking.