search

grambank / pygrambank

Apache License 2.0
4 stars 1 forks source link

remove_empty: tweaks & fixes #72

Closed johenglisch closed 2 years ago

johenglisch commented 2 years ago

  1. The ValueException within the with block caused data corruption.

  2. Added padding so all rows have the same length (can't hurt).

  3. Told the test suite about those cases.

johenglisch commented 2 years ago

No idea, what's up with the test failure -- seems to be coming from clldutils.

.tox/py36/lib/python3.6/site-packages/clldutils/text.py:130: in <module>
    def replace_pattern(pattern: typing.Union[str, re.Pattern], repl, text: str, flags=0) -> str:
E   AttributeError: module 're' has no attribute 'Pattern'

EDIT: btw, only affects python 3.6

ERROR:   py36: commands failed
  py37: commands succeeded
  py38: commands succeeded
  py39: commands succeeded
  py310: commands succeeded
xrotwang commented 2 years ago

py3.6 is no longer supported by clldutils. I fixed the gh action to no longer run py3.6 tests.

xrotwang commented 2 years ago

@johenglisch you'd need to merge master into this branch, though.