search

grambank / pygrambank

Apache License 2.0
4 stars 1 forks source link

Mandatory comments in GB022 and GB023? #92

Open johenglisch opened 2 years ago

johenglisch commented 2 years ago

I happened to stumble a mention of mandatory comments in this issue:

I would suggest requiring comments in the event that both GB022 and GB023 are coded as "1"

@HedvigS Should this be added to the check rules?

HedvigS commented 1 year ago

Hi, sorry i didn't see this earlier.

HedvigS commented 1 year ago

Sure, we could add this. Doesn't seem like a super-important thing but it is a good idea to comment on this if it happens.

we'd have to add it here too: https://github.com/grambank/grambank/wiki/Automatic-quality-checks

johenglisch commented 1 year ago

So, the rule has been implemented and the wiki edited. This should be good.