search

grambank / rgrambank

R package to access and analyse Grambank's CLDF data
Apache License 2.0
3 stars 1 forks source link

Make theo scores #13

Closed HedvigS closed 1 year ago

HedvigS commented 1 year ago

5

HedvigS commented 1 year ago

I'll get going on a test for this function now as well.

HedvigS commented 1 year ago

testthat script added here too. ready for review again whenever

HedvigS commented 1 year ago

Currently, the make_theo_scores takes a fn for the ParameterTable, this is because I know that people have trouble reading in the grambank ParameterTable as it contains unusual structure what with the wiki summary import etc.

We should change this. I think that we should just ask for a df and encourage users to use rcldf to get the ParameterTable for Grambank. In turn, I think we may need to update rcldf to reading the Grambank ParameterTable, I think vroom isn't cutting it - is that right @SimonGreenhill ? See suggestion over there re use of cswvr https://github.com/SimonGreenhill/rcldf/issues/27#issuecomment-1703257650

In the meantime, I'll change this function to just take a df.