search

grambank / rgrambank

R package to access and analyse Grambank's CLDF data
Apache License 2.0
4 stars 1 forks source link

Create language_level_df.R #3

Closed HedvigS closed 1 year ago

HedvigS commented 1 year ago

closes #1

HedvigS commented 1 year ago

I am going to write more functions for this package, and I am going to base branches on this branch since this function is useful in them.

HedvigS commented 1 year ago

test added.

Another step that could be taken here is to change language_level_df() to take long tables as well/instead of just wide tables as is its current behaviour.

HedvigS commented 1 year ago

I'm reworking the function now to just take long format.

HedvigS commented 1 year ago

The function language_level_df() now takes ValueTable in a long format instead of wide.

NB, I'm not changing the column "ID" in the ValueTable, which is a combination of Parameter_ID and Language_ID. I am however changing the Language_ID column. If you want, I can set it so that it also change sthe ID column, up to you.

HedvigS commented 1 year ago

@SimonGreenhill where are the comments I should work through?

SimonGreenhill commented 1 year ago

here in the binarise branch. I was working over there as those functions seem to be needed there as well.

HedvigS commented 1 year ago

here in the binarise branch. I was working over there as those functions seem to be needed there as well.

Aha, okay. I'll go over there and work on the two in unison then.