grambank / rgrambank

R package to access and analyse Grambank's CLDF data
Apache License 2.0
3 stars 1 forks source link

fix package errors caused by NSE in tidyverse #44

Open SimonGreenhill opened 5 months ago

SimonGreenhill commented 5 months ago
binarise: no visible binding for global variable ‘Parameter_ID’
binarise: no visible binding for global variable ‘Language_ID’
gb_recode: no visible binding for global variable ‘Parameter_ID’
gb_recode: no visible binding for global variable ‘Language_ID’
gb_recode: no visible binding for global variable ‘Value’
get_shared_features: no visible binding for global variable
  ‘Language_ID’
get_shared_features: no visible binding for global variable ‘Value’
get_shared_features: no visible binding for global variable
  ‘Parameter_ID’
get_shared_features: no visible binding for global variable ‘.data’
get_shared_features: no visible binding for global variable ‘ID’
get_shared_features: no visible binding for global variable ‘Name’
get_shared_features: no visible binding for global variable ‘shared’
get_values_for_clade: no visible binding for global variable ‘lineage’
get_values_for_clade: no visible binding for global variable
  ‘Language_ID’
language_level_df: no visible global function definition for ‘desc’
language_level_df: no visible binding for global variable ‘n’
language_level_df: no visible binding for global variable ‘Language_ID’
make_theo_scores: no visible binding for global variable ‘Fusion’
make_theo_scores: no visible binding for global variable
  ‘Gender_or_Noun_Class’
make_theo_scores: no visible binding for global variable ‘Flexivity’
make_theo_scores: no visible binding for global variable
  ‘Locus_of_Marking’
make_theo_scores: no visible binding for global variable ‘Word_Order’
make_theo_scores: no visible binding for global variable ‘Value’
make_theo_scores: no visible binding for global variable ‘Language_ID’
make_theo_scores: no visible binding for global variable
  ‘Value_weighted’
make_theo_scores: no visible binding for global variable
  ‘Informativity’
make_theo_scores: no visible binding for global variable ‘Parameter_ID’
make_theo_scores: no visible binding for global variable ‘sum_na’
make_theo_scores: no visible binding for global variable
  ‘sum_informativity’
make_theo_scores: no visible binding for global variable
  ‘informativity_score’
Undefined global functions or variables:
  .data desc Flexivity Fusion Gender_or_Noun_Class ID Informativity
  informativity_score Language_ID lineage Locus_of_Marking n Name
  Parameter_ID shared sum_informativity sum_na Value Value_weighted
  Word_Order
xrotwang commented 5 months ago

I had not heard of NSE before, but reading up on it I must say I'm a bit shocked. It definitely sounds as if R code in packages should be quite a bit different from R code in "end user" scripts, to avoid all this built-in pollution of namespaces (aka environments).

HedvigS commented 5 months ago

I haven't seen these errors but I understand that they are a problem for you. If you want help in addressing them, please let me know what I need to do to replicate them.

SimonGreenhill commented 5 months ago

they're problems for CRAN.

HedvigS commented 5 months ago

Okay. Is there anything I can do to help?

HedvigS commented 5 months ago

Maybe this helps? https://stackoverflow.com/questions/47225714/creating-and-using-new-variables-in-function-in-r-nse-programing-error-in-the-t