Closed DBraun closed 9 months ago
Thanks, but I prefer putting this code inside the backend code generator itself, the way we do with some others (like CMajor) which also have some missing math functions. This case the missing maths functions do not have to be in each architecture file.
Done in https://github.com/grame-cncm/faust/commit/4b429eca45841272794354b3b9f6b691d7993b0e
This fixes an incorrect implementation of
std::remainder
in JAX. Reference: https://en.cppreference.com/w/cpp/numeric/math/remainderPrevious outputs:
New correct outputs:
Note that if we had just used jax.numpy.remainder:
Update: this is okay to merge but I also need to update the architecture impulse tests file: https://github.com/grame-cncm/faust/blob/bb1567047e390f84528ae65d408b0dd627c1cd1e/tests/impulse-tests/archs/impulsejax.py#L29