search

grame-cncm / faust

Functional programming language for signal processing and sound synthesis
http://faust.grame.fr
Other
2.59k stars 323 forks source link

Fix regression because of #1061 #1067

Closed crop2000 closed 1 month ago

crop2000 commented 1 month ago

solve unimportant warning and and solve regression because of fix for #1060. adding osc_enable.ir to rust impulse tests revealed a mistake in the fix for #1060 This PR removes brackets around if when it is not from a select2 instruction.

bluenote10 commented 1 month ago

Are the Rust impulse tests not executed by the CI (GitHub Action) before merging a PR?

sletz commented 1 month ago

No, I still do manual tests, and this regression was not seen locally.

crop2000 commented 1 month ago

no and the test that showed the problem wasn't part of the test set.