search

grame-cncm / faust

Functional programming language for signal processing and sound synthesis
http://faust.grame.fr
Other
2.47k stars 312 forks source link

run_test_cpp.sh requires `tempfile` which isn't portable #137

Open agraef opened 6 years ago

agraef commented 6 years ago

run_test_cpp.sh currently requires a tempfile command which seems to be Debian-specific (and deprecated anyway). I have it neither on Arch nor macOS:

$ ./run_test_cpp.sh 
./run_test_cpp.sh: line 20: tempfile: command not found
ERROR : no files specified; for help type "faust --help"

It would be nice if mktemp could be used instead, this is readily available on macOS and the BSDs, as well as Arch and Debian/Ubuntu and, presumably, most other Linux distros.

Also, it would be nice if there was a make check target in the global Makefile which just runs run_test_cpp.sh "in-place", i.e., after a fresh build using the compiled faust and tools/library in the source (and not whatever faust binary and library happens to be installed on the system). Then we (i.e., package maintainers like @dvzrv and myself) could run make check in our package builds and so have some reasonable level of confidence that the packages we're building are in good working order. (I can probably cook up a recipe for the "in-place" part myself using the existing test facility once run_test_cpp.sh works properly on my system.)

agraef commented 6 years ago

@orlarey, @sletz, anyone? Looks like this was written by @timblechmann a really long time ago, is this still being used at all? Or am I barking up the wrong tree? :)

sletz commented 6 years ago

Probably not used anymore for now. But as part of the cmake move, we want to improve/restore more automatic testing tools.

agraef commented 6 years ago

But I recall that both you and Yann were talking about regression tests not catching the recent pm-eval issue, without tongue-in-cheek, so I'm assuming that someone does run some regression test suite every once in a while. ;-) Is this the one?

sletz commented 6 years ago

Nope.

agraef commented 6 years ago

So where is it? Not public yet?

dblanchemain commented 4 years ago

@agraef After a discussion with Stéphane Letz I allow myself to contact you. I recompile the flanger.dsp example to vst with the -osc and -gui option. faust2lv2 -osc -gui flanger.dsp and faust2faustvst -osc -gui flanger.dsp When I put it as a plugin in Reaper (Linux) or Ardour5 I have nothing. I can control it by the Ardor or Repear osc commands but not by the 5510 port. If I make the following command in a terminal: ss -tuanp

I do not have port 5510 or assimilated. Under Linux, Carla bug with this plugin -osc -gui. By cons the Lv2 plugin for Ardor works very well. I do not understand well.