search

grame-cncm / faust

Functional programming language for signal processing and sound synthesis
http://faust.grame.fr
Other
2.58k stars 322 forks source link

warnings for overloaded virtual when building. #254

Closed giuliomoro closed 5 years ago

giuliomoro commented 5 years ago 
/root/Bela/projects/vfl/render.cpp:2064:22: warning: 'uiTimedItem::modifyZone' hides overloaded virtual function [-Woverloaded-virtual]
        virtual void modifyZone(double date, float v)
                     ^
/root/Bela/projects/vfl/render.cpp:1965:14: note: hidden overloaded virtual function 'uiItem::modifyZone' declared here: different number of parameters (1 vs 2)
        void modifyZone(float v)
             ^
/root/Bela/projects/vfl/render.cpp:3725:14: warning: 'uiMidiCtrlChange::modifyZone' hides overloaded virtual function [-Woverloaded-virtual]
        void modifyZone(int v)
             ^
/root/Bela/projects/vfl/render.cpp:1965:14: note: hidden overloaded virtual function 'uiItem::modifyZone' declared here: type mismatch at 1st parameter ('float' vs 'int')
        void modifyZone(float v)
             ^
/root/Bela/projects/vfl/render.cpp:3765:14: warning: 'uiMidiPitchWheel::modifyZone' hides overloaded virtual function [-Woverloaded-virtual]
        void modifyZone(int v)
             ^
/root/Bela/projects/vfl/render.cpp:1965:14: note: hidden overloaded virtual function 'uiItem::modifyZone' declared here: type mismatch at 1st parameter ('float' vs 'int')
        void modifyZone(float v)
             ^
/root/Bela/projects/vfl/render.cpp:3797:14: warning: 'uiMidiKeyOn::modifyZone' hides overloaded virtual function [-Woverloaded-virtual]
        void modifyZone(int v)
             ^
/root/Bela/projects/vfl/render.cpp:1965:14: note: hidden overloaded virtual function 'uiItem::modifyZone' declared here: type mismatch at 1st parameter ('float' vs 'int')
        void modifyZone(float v)
             ^
/root/Bela/projects/vfl/render.cpp:3829:14: warning: 'uiMidiKeyOff::modifyZone' hides overloaded virtual function [-Woverloaded-virtual]
        void modifyZone(int v)
             ^
/root/Bela/projects/vfl/render.cpp:1965:14: note: hidden overloaded virtual function 'uiItem::modifyZone' declared here: type mismatch at 1st parameter ('float' vs 'int')
        void modifyZone(float v)
             ^
/root/Bela/projects/vfl/render.cpp:3862:14: warning: 'uiMidiKeyPress::modifyZone' hides overloaded virtual function [-Woverloaded-virtual]
        void modifyZone(int v)
             ^
/root/Bela/projects/vfl/render.cpp:1965:14: note: hidden overloaded virtual function 'uiItem::modifyZone' declared here: type mismatch at 1st parameter ('float' vs 'int')
        void modifyZone(float v)
             ^

Is there anything to be worried about, or shall I just add -Wno-overloaded-virtual?

sletz commented 5 years ago

Can you send me your render.cpp file ? Thanks

giuliomoro commented 5 years ago

render.cpp.zip here it is

sletz commented 5 years ago

Possible fixed in https://github.com/grame-cncm/faust/commit/de5ae5d06ec3364b0796c76f220f17af4c42d81f

Can you test and report ?

giuliomoro commented 5 years ago

yes that work thanks. Closed de5ae5d

giuliomoro commented 5 years ago

Actually sorry, that was not enough. I didn't realize I still had -Wno-overloaded-virtual enabled.

This file (obtained with faust2bela -tobela -midi -nvoices 2 guitarMIDI.dsp) render.zip gives:

/root/Bela/projects/guitarMIDI/render.cpp:2061:22: warning: 'uiTimedItem::modifyZone' hides overloaded virtual function [-Woverloaded-virtual]
        virtual void modifyZone(double date, float v)
                     ^
/root/Bela/projects/guitarMIDI/render.cpp:1962:14: note: hidden overloaded virtual function 'uiItem::modifyZone' declared here: different number of parameters (1 vs 2)
        void modifyZone(float v)
sletz commented 5 years ago

Fixed in https://github.com/grame-cncm/faust/commit/66eec5334f3c8253b47bcf251f6d8541d59e6c21.