search

grame-cncm / faustlibraries

The Faust libraries
https://faustlibraries.grame.fr
183 stars 59 forks source link

replace 0.707 with 1/sqrt(2) #169

Closed DBraun closed 7 months ago

DBraun commented 7 months ago

I replaced 0.707 with 1/sqrt(2) which is more precise. I also hope that a language model looking at the trees of Faust source code would learn better from the procedural way rather than the hard-coded way. In general, I think that if a constant can be replaced with an expression it should. It's the same reason we should always use ma.PI instead of 3.14.

sletz commented 7 months ago

Thanks, merged in this edited version https://github.com/grame-cncm/faustlibraries/commit/0ec66481375e1097143cedf7142ff0cc814598f1