FaustLive fails to build with netjack support

[agraef]

This used to work (make NETJACK=1), but with the very latest faust from master-dev it now fails with:

g++ -c -pipe -march=x86-64 -mtune=generic -O2 -pipe -fstack-protector-strong -fno-plt -Wall -W -D_REENTRANT -DAPP_VERSION=\"2.0\" -DLLVM_VERSION=\"7.0.0\" -DHTTPCTRL -DQRCODECTRL -DJACK -DNETJACK -DQT_NO_DEBUG -DQT_GUI_LIB -DQT_NETWORK_LIB -DQT_CORE_LIB -DQT_SHARED -I/usr/share/qt4/mkspecs/linux-g++ -I. -I/usr/include/qt4/QtCore -I/usr/include/qt4/QtNetwork -I/usr/include/qt4/QtGui -I/usr/include/qt4 -I. -I/opt/local/include -I../../src/Audio -I../../src/MenusAndDialogs -I../../src/MainStructure -I../../src/Network -I../../src/Utilities -I../../src/Audio/JA -I../../src/Audio/NJ_Slave -I../../src/objectsFolder -o ../../src/objectsFolder/NJs_audioFader.o ../../src/Audio/NJ_Slave/NJs_audioFader.cpp
../../src/Audio/NJ_Slave/NJs_audioFader.cpp: In constructor ‘NJs_audioFader::NJs_audioFader(int, std::__cxx11::string, int, int, int, QObject*)’:
../../src/Audio/NJ_Slave/NJs_audioFader.cpp:14:75: error: no matching function for call to ‘netjackaudio::netjackaudio(int&, const string&, int&, int&, int&)’
 : QObject(parent), netjackaudio(celt, master_ip, master_port, mtu, latency)
                                                                           ^
In file included from ../../src/Audio/NJ_Slave/NJs_audioFader.h:18,
                 from ../../src/Audio/NJ_Slave/NJs_audioFader.cpp:11:
/usr/include/faust/audio/netjack-dsp.h:170:9: note: candidate: ‘netjackaudio::netjackaudio(int, const string&, int, int, int, int, int)’
         netjackaudio(int net_format,
         ^~~~~~~~~~~~
/usr/include/faust/audio/netjack-dsp.h:170:9: note:   candidate expects 7 arguments, 5 provided
/usr/include/faust/audio/netjack-dsp.h:37:7: note: candidate: ‘netjackaudio::netjackaudio(const netjackaudio&)’
 class netjackaudio : public audio
       ^~~~~~~~~~~~
/usr/include/faust/audio/netjack-dsp.h:37:7: note:   candidate expects 1 argument, 5 provided
make[2]: *** [Makefile-qt:549: ../../src/objectsFolder/NJs_audioFader.o] Error 1
make[2]: Leaving directory '/home/ag/Sources/github/faustlive/Build/Linux'
make[1]: *** [Makefile:61: all] Error 2
make[1]: Leaving directory '/home/ag/Sources/github/faustlive/Build/Linux'
make: *** [Makefile:17: all] Error 2

This is on Linux (Arch/Manjaro, Jack2 1.9.12, gcc 8.2.1 20180831), using the following command for compilation:

make arch=Linux STATIC=0 NETJACK=1 qm=qmake-qt4

But the issue is with a Faust header, so it probably affects the other platforms as well. Building with NETJACK=0 works fine.

[sletz]

Fixed in https://github.com/grame-cncm/faustlive/commit/413182f0a7f60d89cba9ad14e65ef20ee37d1987, although it has been a while since I tested the NetJack support...

[agraef]

Works, many thanks!