search

grame-cncm / faustlive

Advanced self-contained prototyping environment for the Faust programming language
Other
80 stars 18 forks source link

Text labels for arbitrary numbers are invisible on macOS Mojave #22

Open 1l0 opened 5 years ago

1l0 commented 5 years ago

It can be selected to see what number is but normally white text on white background on any themes. Screen Shot 2019-06-03 at 12 50 13

ahihi commented 4 years ago

it seems this is a more general issue with macOS's dark mode being incompletely supported, resulting also in black text on a dark grey background etc.

i worked around this by adding NSRequiresAquaSystemAppearance = YES to the app's Info.plist, which enforces the light mode.

DocSunset commented 2 years ago

I've noticed that text is unreadable on my Arch Linux installation as well, presumably due to similar incomplete support for the dark theme set in my GUI toolkit.

sletz commented 2 years ago

Are you able to compile yourself: https://github.com/grame-cncm/faustlive and https://github.com/grame-cncm/faustlive/tree/master/Build and possibly hack the code to fix it?

DocSunset commented 2 years ago

I had a bit of trouble compiling because I forgot to git submodule update --init --recursive, but I managed it in the end. After a bit of poking around, I noticed that the default stylesheets are overridden in a number of places with calls to setStyleSheet. Considering at least one text label was overridden to have color: black, I thought this might be related to the problem, so I commented out all of the stylesheet overrides. This significantly improved the situation, enough so that I'm willing to state with certainty that these stylesheet overrides are the problem.

I leave it to you lovely maintainers to decide how best to proceed. Personally I don't mind the default styles.

sletz commented 2 years ago

Can you prepare a pull request with your changes ?