search

grame-cncm / guidolib

Guido project - music score layout engine - music description language
http://guido.grame.fr
Mozilla Public License 2.0
152 stars 34 forks source link

This label is not supported (inverted turn), can you add a font like this? #157

Closed zhwei8090 closed 2 years ago

zhwei8090 commented 2 years ago

Our font library does not have this symbol, can you support it? image

zhwei8090 commented 2 years ago

@dfober Can a font like this be added? Our textbook is like this

dfober commented 2 years ago

Yes, I'll have a look. I'm really not an expert in font design (are you?) but I'll try to add it.

zhwei8090 commented 2 years ago

I don't have the original file here, otherwise we can design and add it (if you have it, can you send me a copy of the original font file, thank you very much)

dfober commented 2 years ago

The guido font file is part of the src code and is available on github.

zhwei8090 commented 2 years ago

Hahaha, this is different from what I understand, I want to know the original file for making ttf, such as ps and the like

dfober commented 2 years ago

There is no such file. The font is also available as svg font, but it's only a svg export of the ttf file (using fontforge).

zhwei8090 commented 2 years ago

ok,thank you very much

zhwei8090 commented 2 years ago

It's really not easy to add this, I haven't succeeded after an hour, I thought it was very simple

dfober commented 2 years ago

Thanks for trying. I'll also try. :-)

dfober commented 2 years ago

That's done. Note that \turn has now a new type: invertedb that you should use for the new glyph. See the guido doc Can you check and close this issue if that's fine.

arshiacont commented 2 years ago

The new TTF font breaks all music symbols when a [regular] score is rendered. Haven't tested the SVG generartor but TTF is definitely broken. If I revert just the font iit works fine. guess the addition of the new symbol has broken things somewhere... .

dfober commented 2 years ago

could you post a picture of what happens?

arshiacont commented 2 years ago

The first two measures of Suite Bergamesque by Debussy!! 😜 (coloring is mine) image

dfober commented 2 years ago

I guess you get this on iOS?

arshiacont commented 2 years ago

i do.. also in the simulator (thus OSX)

arshiacont commented 2 years ago

If I just use the old font with the new engine everything is fine (but there will be a missing symbol at some point I guess)

dfober commented 2 years ago

I'll send you another version (by email).

arshiacont commented 2 years ago

The font version you sent by email works fine and has corrected the issue.

dfober commented 2 years ago

Ok, I'll update the repository as soon as possible.

dfober commented 2 years ago

The font has been updated and pushed to github. Can you check?

zhwei8090 commented 2 years ago

@dfober Verified, no problem