Partial Solution for #154

grame-cncm / guidolib

Guido project - music score layout engine - music description language

http://guido.grame.fr

Mozilla Public License 2.0

152 stars 34 forks source link

Partial Solution for #154 #162

Closed arshiacont closed 1 year ago

arshiacont commented 2 years ago

Fix nested beaming inclusion for fSmallerBeam in GRVoiceManager
Fix parent beam position offset with smaller beams when on the system level

If this PR validates regression tests then it can be merged since this partial result is more acceptable than current for this special case.

arshiacont commented 2 years ago

As is, this PR will lead to instead of for the added regression-test:

  \clef<"f4"> \staff<2> 
   \stemsUp \beamBegin:1 \beamBegin:2 f-1/16 c0/16 d0/16 e0/16 \beamEnd:2 \beamBegin:2 
   \staff<1> \stemsDown f0/16 a0/16 c1/16 d1/16 \beamEnd:1 \beamEnd:2 _/2 ]
 , 
[ \staff<2>  \clef<"f4"> \key<0> empty/1 ]}

Note that this is not perfect! We can also continue working on this branch and merge afterwards! Your call @dfober

dfober commented 2 years ago

The proposed changes improve the rendering but break a number of tests (and fix one open issue). I'll see if I can do better and leave the PR open until then.

dfober commented 1 year ago

Closed because the proposed modifications are part of the last commits