search

grame-cncm / libmusicxml

A C/C++ library to support the MusicXML format.
Mozilla Public License 2.0
156 stars 35 forks source link

Latest tag is invalid #59

Open dvzrv opened 2 years ago

dvzrv commented 2 years ago

Hi! I package this project for Arch Linux.

Your latest tag is invalid. Please release one that follows semver and that sorts newer than 3.21, as I will otherwise not package it.

dfober commented 2 years ago

I don't understand why v.3.22 don't sort newer than v.3.21.

dvzrv commented 2 years ago

I don't understand why v.3.22 don't sort newer than v.3.21.

Well, apart from v.3.21 not existing in this repository, both would not be valid according to semver.

Are you sure that you want to replace your major version with v? To me it rather looks like a typo while creating the tag. :)

dfober commented 2 years ago

ok, I'll try to tag according to semver in the future. If I create a new tag 3.2.2, would it be ok for you? Do you need a new release with this tag?

dvzrv commented 2 years ago

If I create a new tag 3.2.2, would it be ok for you?

3.2.2 would also sort lower than 3.21. You probably meant 3.22? FWIW, it is completely fine to keep the v prefix. Consistency is important.

Do you need a new release with this tag?

Yes, please tag https://github.com/grame-cncm/libmusicxml/commit/ea73d1165d3b0242528e65c6da1cfc05f57b6b7d with v3.22. Thanks! :heart:

dfober commented 2 years ago

done