Closed BFuhry closed 1 year ago
Intel-Confidential-Compute-for-X/README.md
line 84 at r4 (raw file):
## Contents
Keys folder is missing from contents. It should also be added
Intel-Confidential-Compute-for-X/README.md
line 54 at r4 (raw file):
- Install the necessary build dependencies: - Ubuntu 18.04:
The dependencies are common for Ubuntu 18.04 and Ubuntu 20.04, is it okay to mention only Ubuntu 18.04
Intel-Confidential-Compute-for-X/README.md
line 45 at r4 (raw file):
### For executing an "Intel® Confidential Compute for X" image - Hardware requirements: An Intel® SGX-enabled bare metal machine or a VM.
Currently, this repo is enabled only for Azure VM's not for any Intel SGX enabled bare metal machine
Intel-Confidential-Compute-for-X/workloads/pytorch/README.md
line 48 at r4 (raw file):
4. Run the generated PyTorch image using below command: ```sh docker run --net=host --device=/dev/sgx/enclave -it gsc-pytorch-encrypted
This step is not required, and also not mentioned as part of other workloads, It is covered in next step
Intel-Confidential-Compute-for-X/workloads/sklearn/README.md
line 5 at r4 (raw file):
In the following two sections, we explain how a Docker image for a Gramine-protected Scikit-learn version can be built and how the image can be executed. We assume that the [prerequisites](https://github.com/gramineproject/contrib/tree/master/Intel-Confidential-Compute-for-X/README.md)
Currently, all hyperlinks are relative path, but this path is absolute path and when you refer it is returning 404 error. Should this also be relative path instead of absolute path?
Intel-Confidential-Compute-for-X/workloads/sklearn/base_image_helper/README.md
line 7 at r4 (raw file):
- Install dependencies: - Ubuntu 18.04:
This section here implies that this workload is specific only for Ubuntu 18.04, can we rephrase this in order to avoid confusion
Intel-Confidential-Compute-for-X/workloads/pytorch/README.md
line 15 at r6 (raw file):
1. Clone the Gramine Contrib repository: ```sh $ git clone --depth 1 https://github.com/gramineproject/contrib.git
Sorry, I missed this earlier, But there was one commit which removed $ symbol from sh commands. So, this should also be taken care back again
https://github.com/gramineproject/contrib/commit/0deede256f2dcbc5f6c2216483979e9830bcf15e
This change is