gramineproject / examples

Sample applications configs for Gramine
BSD 3-Clause "New" or "Revised" License
30 stars 22 forks source link

tag examples repos for releases #42

Closed mythi closed 2 years ago

mythi commented 2 years ago

In one of demos I'm using v1.1 Gramine (I know I shouldn't) with examples from this repo. My problem is: how to clone this repo that matches v1.1 functionality.

dimakuv commented 2 years ago

Here is the mapping, collected by me with some pointers from @anjalirai-intel (thanks!):

I agree that we should tag these commits with v1.0, v1.1, ... -- corresponding to the tags in the core Gramine repo. @mkow Is there anything special we should do with this, or can I just tag the commits?

mkow commented 2 years ago

Nah, just tag them, but please be careful as pushing tags goes without review.

dimakuv commented 2 years ago

@mythi I just pushed the (lightweight) tags v1.0, v1.1, ..., with commit mappings as described above.

I'll be grateful if you can verify that these tags work (I mean, at least v1.1 that you're targeting).

mythi commented 2 years ago

I'll be grateful if you can verify that these tags work (I mean, at least v1.1 that you're targeting).

I can confirm that with the tag my Dockerfile builds OK again:

thanks!

diff --git a/demos/cc-gramine-demo/build/Dockerfile b/demos/cc-gramine-demo/build/Dockerfile
index 7e76b09..1b254fc 100644
--- a/demos/cc-gramine-demo/build/Dockerfile
+++ b/demos/cc-gramine-demo/build/Dockerfile
@@ -35,7 +35,7 @@ RUN apt-get update \
     libsgx-quote-ex \
     libsgx-dcap-quote-verify-dev

-RUN git clone https://github.com/gramineproject/gramine.git
+RUN git clone -b v1.1 --depth 1 https://github.com/gramineproject/gramine.git

 WORKDIR /gramine
 COPY 0001-ra-tls-secret-prov-use-cert-manager-filenames.patch .
@@ -90,7 +90,7 @@ COPY --from=gramine /gramine/meson_build_output /gramine/meson_build_output/
 RUN mkdir /ra-tls-secret-prov
 COPY --from=gramine /gramine/CI-Examples/ra-tls-secret-prov/secret_prov_server_dcap /ra-tls-secret-prov

-RUN git clone --depth=1 https://github.com/gramineproject/examples.git
+RUN git clone -b v1.1 --depth=1 https://github.com/gramineproject/examples.git
 WORKDIR /examples/pytorch

 ENV PATH="${PATH}:/gramine/meson_build_output/bin"