search

gramineproject / gramine

A library OS for Linux multi-process applications, with Intel SGX support
GNU Lesser General Public License v3.0
608 stars 202 forks source link

Move to C11 atomics #20

Open mkow opened 3 years ago

mkow commented 3 years ago

Description of the problem

We should migrate away from the mixture of GCC built-ins and some legacy custom atomics to C11 atomics.

For reasons why not to stay with GCC built-ins please see the discussion under gramineproject/graphene#1593.

dimakuv commented 3 years ago

@vijaydhanraj Please send a comment "Assign to me" here, so I can assign you in the GitHub interface (a person can be assigned to an issue only after he/she wrote a comment).

vijaydhanraj commented 3 years ago

@dimakuv please assign this issue to me.

dimakuv commented 1 year ago

@mkow Do we still want this? I remember Borys was highly against this, and generally we don't seem to be moving in the direction of C11 atomics.

mkow commented 1 year ago

I'd keep it open until we either move to C11 atomics or find a way to make GCC built-ins safe against cases like the one mentioned in the issue description.