search

gramineproject / gramine

A library OS for Linux multi-process applications, with Intel SGX support
GNU Lesser General Public License v3.0
603 stars 201 forks source link

[tests] Add `-Wno-implicit-function-declaration` for LTP build #2005

Closed dimakuv closed 1 month ago

dimakuv commented 1 month ago

Description of the changes

Currently used version of LTP has a bug that results in the following build error, e.g. when using Clang v18 on Ubuntu 24.04:

clone301.c:136:8: error: call to undeclared function 'pidfd_send_signal'

This is because Clang promoted "implicit function declaration" check from a warning to an error starting from Clang v16. This commit adds -Wno-implicit-function-declaration flag to CFLAGS during LTP build.

Newer LTP releases fixed this bug, so in the future, when Gramine uses newer LTP, this commit should be reverted.

Reported by @woju.

How to test this PR?

Build LTP with Clang on Ubuntu 24.04.

This change is Reviewable

dimakuv commented 1 month ago

Jenkins, retest Jenkins-Direct-Sanitizers please (LTP test clock_gettime04 failed with CLOCK_REALTIME: Difference between successive readings greater than 5 ms, seems like an unfortunate case of a VM's vCPU being descheduled for too long)

dimakuv commented 1 month ago

Jenkins, retest Jenkins-Direct-Sanitizers please (LTP test clock_gettime04 failed again, same issue)