Closed adarshan-intel closed 3 months ago
adarshan-intel
commented
3 months ago gsc.py line 264 at r1 (raw file):
Aren't you supposed to also check that `version_id == 9`? Otherwise it seems that your code will try to use `quay.io/centos/centos:stream8` even for CentOS 8.
Done.
adarshan-intel
commented
3 months ago templates/quay.io/centos/centos/apploader.template line 1 at r1 (raw file):
Isn't this file exactly like `templates/centos/apploader.template`? Please instead use the simple: ``` {% extends "centos/apploader.template" %} ``` See a similar example for Ubuntu: https://github.com/gramineproject/gsc/blob/master/templates/ubuntu/apploader.template. Recall that Ubuntu is derived from Debian, which is similar to CentOS Stream being derived from CentOS.
Done.
adarshan-intel
commented
3 months ago templates/quay.io/centos/centos/Dockerfile.build.template line 1 at r1 (raw file):
ditto for all these files -- can't they all be derived from `templates/centos/` files?
Done.
adarshan-intel
commented
3 months ago templates/quay.io/centos/centos/Dockerfile.compile.template line 74 at r1 (raw file):
Why do you have these random packages like R?
Removed unnecessary packages
adarshan-intel
commented
3 months ago Closing this PR as the branch name should follow this convention - name/feature. Updated PR #206
Description of the changes
Add support for CentOS Stream 9 using the image - quay.io/centos/centos:stream9 to GSC.
How to test this PR?
To test this PR, set follow similar procedure as followed with Ubuntu and do gsc build and signing commands.
This change is