grammarly / focal

Program user interfaces the FRP way.
Apache License 2.0
723 stars 34 forks source link

Issue a warning for non-behavior observable props #26

Closed blacktaxi closed 6 years ago

blacktaxi commented 6 years ago

Originally reported in #25

This PR fixes an inconsistency in how "empty observable warning" is issued between cases with one and many observable props. Since the warning is already issued for non-behavior observables in the RenderMany case, this fix only adds it to RenderOne case.

We will need to update the wording in the warning message since it will no longer warn only for an empty observable case.

Also I don't consider this to be a breaking change, so I'm not bumping the minor version.