search

grammarly / gector

Official implementation of the papers "GECToR – Grammatical Error Correction: Tag, Not Rewrite" (BEA-20) and "Text Simplification by Tagging" (BEA-21)
Apache License 2.0
891 stars 216 forks source link

Update GECToR to use latest AllenNLP (inference time only) #166

Open damien2012eng opened 2 years ago

damien2012eng commented 2 years ago

Hello. First of all, thanks for the wonderful work! Our team is deciding to update GECToR to use latest AllenNLP, so that it can be compatible to our existing system. We understand that it is not an easy job to do the updating for the whole codebase. Therefore, our team comes up a plan to only update the inference part and consumes the pre-trained models. Could you please take a look at and let us know if it makes sense to you? Here

Thanks so much!

skurzhanskyi commented 2 years ago

Hi @damien2012eng Great news! Thanks for sharing. In general, the plan looks good to me. I understand why you decided to work only with the inference part. When ready, we will be happy to add your fork/branch to the repository's README.

skurzhanskyi commented 1 year ago

Checkout gector-fast repository

damien2012eng commented 1 year ago

@skurzhanskyi I checked out the gector-fast repo. However, it still uses the old Python and legacy version of Pytorch. Besides, our PRs will be ready soon (currently in the internal review).

damien2012eng commented 1 year ago

@skurzhanskyi Please review the first PR. Two more PRs are coming!

Jason3900 commented 1 year ago

@skurzhanskyi Please review the first PR. Two more PRs are coming!

I've update the pytorch version and dependencies. You can try it now.