search

grammarly / omniconf

Configuration library for Clojure that favors explicitness
Apache License 2.0
193 stars 16 forks source link

Feature request: Ability to add data-readers when reading a configuration file #12

Open neuromantik33 opened 5 years ago

neuromantik33 commented 5 years ago

Hello, I have a perhaps rare but not unheard of usecase where I need to read a configuration file with custom reader macros (like integrant's ig/ref). Therefore I've provided a simple patch which breaks the api somewhat (the depracted quit-on-error? arity) @ here.

Can you tell me if this goes against the philosophy of omniconf as I use the latter as a centralized configuration system-of-record which contains many other types of configurations, some of which make use of reader macros.

Thanks for any feedback,

Nicolas

alexander-yakushev commented 5 years ago

Hi Nicolas,

I think there is no problem with Omniconf supporting such feature. I would accept this as a PR if you don't mind implementing it non-breakingly, e.g. by introducing a dynamic variable, maybe? You could than mention it in the dosctring.