grammarly / rocker

Rocker breaks the limits of Dockerfile.
Other
1.34k stars 88 forks source link

label and t args are missing #166

Closed dmytroleonenko closed 6 years ago

dmytroleonenko commented 7 years ago

With docker one can build an image with docker build -t myname:my_ver --label mylabel=myvalue . rocker binary doesn't any of these

Should be easy to fix I suppose

ctrlok commented 7 years ago

You can do it with variables.

☁  cat Rockerfile
FROM ubuntu
RUN apt-get update
LABEL {{ .myLabel }}
TAG {{ .myTag }}%                                                                                                                           

# Just printing file whithout build
☁  rocker build --var myLabel="LABEL test" --var myTag=some:version --print
FROM ubuntu
RUN apt-get update
LABEL LABEL test
TAG some:version%

I think that way is much more cleaner that docker way, but we can discuss about feature parity of docker build.

bendikro commented 7 years ago

Supporting this makes transitioning to Rocker much easier.

ybogdanov commented 6 years ago

Thanks for requesting. Unfortunately, we are discontinuing this project. See the notice here: https://github.com/grammarly/rocker/blob/master/README.md

Closing this issue as we are not able to implement it. Sorry.