grammarly / rocker

Rocker breaks the limits of Dockerfile.
Other
1.34k stars 88 forks source link

Fix #182 cleanup export containers after build #193

Closed masterzen closed 6 years ago

masterzen commented 6 years ago

I was fed up of cleaning up rocker exports containers and volumes on our CI server, so I'm sending this PR.

When rocker build is used with --clean-exports, then all export/import containers and volumes are removed at the end of the build.

This isn't compatible with caching, so --clean-exports removes caching of EXPORT/IMPORT.

masterzen commented 6 years ago

The tests seem to fail for some non-code related reasons...

ybogdanov commented 6 years ago

Thanks for your contribution. Unfortunately, we are discontinuing this project. See the notice here: https://github.com/grammarly/rocker/blob/master/README.md

Closing this PR for now. Sorry.