Closed carafelix closed 6 months ago
Attention: Patch coverage is 7.89474%
with 35 lines
in your changes are missing coverage. Please review.
Project coverage is 63.61%. Comparing base (
63bc0fa
) to head (ccfa370
).
Files | Patch % | Lines |
---|---|---|
src/context.ts | 0.00% | 33 Missing :warning: |
src/command.ts | 50.00% | 2 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
I'm pretty sure test are failing because of a connection problem. It get's stuck at: Pinging Codecov.
I'll remove Codecov as a requirement for merge. I haven't had the time to take a proper look at this yet, but I will ASAP. Thanks for the PQ!
I'll remove Codecov as a requirement for merge.
Test are passing locally to be said.
Hi! Did you test this on runtime too?
Ups, looks like I didn't check well enough, let me get it right.
commit 331b372 condense all the changes.
SetMyCommandsParams
from two or more different sources, based on the fact that toSingleScopeArgs
group them by language. Merge function its basically a reducer that concat lang.commands
arrays of the same language and returns an array of setMyCommandsParams
. It does not break scoping since it's performed after the toSingleScopeArgs
function. If an empty array is passed, it does not throw, if only one Commands instance is passed it treats it ok.PD: i'm sorry about the multiple bloat commits (fmt and duplicate commit history, i'll be more aware next time on both things, specially the branch management since the fmt i'll just add it to the pre-commit task)
ref #15
Closed because messed up branch management
Add ability to do, e.g:
Might be too rudimentary of an implementation?