grammyjs / commands

Work-in-progress plugin for managing commands with grammY.
https://grammy.dev
MIT License
12 stars 2 forks source link

feat: enable mixin of commands for ctx #12

Closed carafelix closed 6 months ago

carafelix commented 6 months ago

Add ability to do, e.g:

await c.setMyCommands(userCommands, adminCommands)

Might be too rudimentary of an implementation?

codecov[bot] commented 6 months ago

Codecov Report

Attention: Patch coverage is 7.89474% with 35 lines in your changes are missing coverage. Please review.

Project coverage is 63.61%. Comparing base (63bc0fa) to head (ccfa370).

Files Patch % Lines
src/context.ts 0.00% 33 Missing :warning:
src/command.ts 50.00% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #12 +/- ## ========================================== - Coverage 68.13% 63.61% -4.53% ========================================== Files 7 7 Lines 408 437 +29 Branches 66 65 -1 ========================================== Hits 278 278 - Misses 128 157 +29 Partials 2 2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

carafelix commented 6 months ago

I'm pretty sure test are failing because of a connection problem. It get's stuck at: Pinging Codecov.

roziscoding commented 6 months ago

I'll remove Codecov as a requirement for merge. I haven't had the time to take a proper look at this yet, but I will ASAP. Thanks for the PQ!

carafelix commented 6 months ago

I'll remove Codecov as a requirement for merge.

Test are passing locally to be said.

roziscoding commented 6 months ago

Hi! Did you test this on runtime too?

carafelix commented 6 months ago

Ups, looks like I didn't check well enough, let me get it right.

carafelix commented 6 months ago

commit 331b372 condense all the changes.

Summary

PD: i'm sorry about the multiple bloat commits (fmt and duplicate commit history, i'll be more aware next time on both things, specially the branch management since the fmt i'll just add it to the pre-commit task)

KnorpelSenf commented 6 months ago

ref #15

carafelix commented 6 months ago

Closed because messed up branch management