grammyjs / commands

Work-in-progress plugin for managing commands with grammY.
https://grammy.dev
MIT License
12 stars 2 forks source link

fix: filter out regex names from .toArgs #25

Closed carafelix closed 4 months ago

carafelix commented 4 months ago

this will fix #24 only for regex's. Command names containing UpperCase letters will still thrown when calling SetMyCommand on them.

They should at least be discouraged. I don't know if it's better to enforce right from the bat the use of lowercaseonly commands or just a mention in the docs. Because they will still register and be handled correctly, but could not be pass to SetMyCommand

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Please upload report for BASE (next@efa55cc). Learn more about missing BASE report.

:exclamation: Current head 981fbaf differs from pull request most recent head 1ad9e15

Please upload reports for the commit 1ad9e15 to get more accurate results.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## next #25 +/- ## ======================================= Coverage ? 84.02% ======================================= Files ? 8 Lines ? 582 Branches ? 91 ======================================= Hits ? 489 Misses ? 92 Partials ? 1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.