search

grammyjs / conversations

Conversational interfaces for grammY.
https://grammy.dev/plugins/conversations
MIT License
44 stars 17 forks source link

Do not add maxMilliseconds if 0 or undefined #102

Closed KnightNiwrem closed 3 months ago

KnightNiwrem commented 3 months ago

This also has the effect of not giving maxMilliseconds if it is 0 (falsy). A timeout of 0ms makes no sense anyway.

codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 94.59%. Comparing base (e4045f2) to head (5f977e6).

Files Patch % Lines
src/conversation.ts 33.33% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #102 +/- ## ========================================== - Coverage 94.81% 94.59% -0.23% ========================================== Files 4 4 Lines 849 851 +2 Branches 122 127 +5 ========================================== Hits 805 805 - Misses 43 45 +2 Partials 1 1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.