grammyjs / conversations

Conversational interfaces for grammY.
https://grammy.dev/plugins/conversations
MIT License
44 stars 17 forks source link

fix: update oson dependency to fix constructor.name error #69

Closed evermake closed 1 year ago

codecov-commenter commented 1 year ago

Codecov Report

Base: 95.87% // Head: 95.87% // No change to project coverage :thumbsup:

Coverage data is based on head (80c5bb4) compared to base (d6ff081). Patch coverage: 100.00% of modified lines in pull request are covered.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #69 +/- ## ======================================= Coverage 95.87% 95.87% ======================================= Files 4 4 Lines 849 849 Branches 124 124 ======================================= Hits 814 814 Misses 33 33 Partials 2 2 ``` | [Impacted Files](https://codecov.io/gh/grammyjs/conversations/pull/69?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=grammyjs) | Coverage Δ | | |---|---|---| | [src/deps.deno.ts](https://codecov.io/gh/grammyjs/conversations/pull/69?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=grammyjs#diff-c3JjL2RlcHMuZGVuby50cw==) | `100.00% <100.00%> (ø)` | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=grammyjs). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=grammyjs)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

dcdunkan commented 1 year ago

@KnorpelSenf Is there a reason for not using lib.deno.dev import for oson?

KnorpelSenf commented 1 year ago

No, not really. I was hesitant because it's a third-party service, so I only really wanted to use it where nothing else is possible, namely for peer deps. But this incident shows that perhaps I should give up my hopes on Deno actually delivering something useful, and just use lib.deno.dev everywhere. After all, this would much better reflect our Node build.