search

grammyjs / conversations

Conversational interfaces for grammY.
https://grammy.dev/plugins/conversations
MIT License
48 stars 17 forks source link

Added date validation #93

Open FreezyEx opened 10 months ago

FreezyEx commented 10 months ago

Added Date validation to the Form class. Valid syntax defined here

KnorpelSenf commented 10 months ago

Cool idea, it looks good on first sight, but I'll do a proper review tonight. Could you fix CI in the meantime?

KnorpelSenf commented 9 months ago

Please revert that fix. You committed a pnpm lock file and reformatted the entire project.

If you do not have Deno installed or are unsure how to fix up CI, just drop me a comment and I can fix it up :)

FreezyEx commented 9 months ago

Please revert that fix. You committed a pnpm lock file and reformatted the entire project.

If you do not have Deno installed or are unsure how to fix up CI, just drop me a comment and I can fix it up :)

Installed Deno and reverted. I cannot get format-and-lint to work without modifying the whole file with deno fmt

KnorpelSenf commented 9 months ago

I can fix it up later today

codecov[bot] commented 9 months ago

Codecov Report

Attention: 11 lines in your changes are missing coverage. Please review.

Comparison is base (3124f1f) 95.83% compared to head (8a8fe76) 94.60%.

Files Patch % Lines
src/form.ts 8.33% 11 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #93 +/- ## ========================================== - Coverage 95.83% 94.60% -1.23% ========================================== Files 4 4 Lines 840 853 +13 Branches 124 124 ========================================== + Hits 805 807 +2 - Misses 33 44 +11 Partials 2 2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

KnorpelSenf commented 9 months ago

Oh nice, you got it already

FreezyEx commented 9 months ago

Oh nice, you got it already

Do I need to do anything else?

roziscoding commented 9 months ago

Oh nice, you got it already

Do I need to do anything else?

it seems the job is still failing. @KnorpelSenf do you wanna take a look at it?