search

grammyjs / emoji

Helpers for sending emojis.
https://grammy.dev/plugins/emoji
MIT License
9 stars 2 forks source link

Issue #13: allowed concatenate custom values #14

Closed niusia-ua closed 1 year ago

niusia-ua commented 1 year ago

The EmojiName type can now take any string value, which increases DX by not having to create hard-to-read constructs to concatenate anything that isn't an emoji. By the way, the string & {} construction allows to leave autocompletion working.

KnorpelSenf commented 1 year ago

@andrrms is not responding. I sent another DM now, but if we are being left in silence, I'll take over.

dcdunkan commented 1 year ago

Thank you so much for your contribution.

@KnorpelSenf and I discussed few things about this plugin, so, we won't be releasing a new version if you are planning to re-write the plugin soon. It is mostly because of #16 actually, where we realised that we weren't using official names for emoji, instead we were using what Emojipedia named them. So, in that pull request the updated list contains some breaking name changes, because we corrected some. So, now we have two options:

  1. Merge both #16 and this PQ, and release a MINOR version. So even if the users update the plugin, instead of empty strings for emoji with corrected names, there'll at least be its old name.
  2. Wait for your re-write PQ (if you are able to work on it), so, if you want to, you can have some breaking changes there; so when we release a MAJOR version with that, the corrected names won't be an issue.

I'm in favour of 2. So, for now, we'll just merge this and keep the plugin up-to-date. Let us know about the reworked plugin plans. Thanks again.

niusia-ua commented 1 year ago

Great! I'll be working on reworking the plugin in a few days. You won't have to wait long.

In general, I only want to fix the structure of the plugin. There will be no significant changes to the plugin's functionality. If there is something you want to change or add, please let me know, I will be very interested to work on it.