search

grammyjs / emoji

Helpers for sending emojis.
https://grammy.dev/plugins/emoji
MIT License
9 stars 2 forks source link

Adds new emoji #15

Closed MaicolAntali closed 1 year ago

MaicolAntali commented 1 year ago

Adds new emoji & fixes the order according to the official unicode list. I have also fixed some formatting issue.

⚠️ Have some breaking changes: Some names have changed to follow the official naming convention. E.g: From: "hugging_face": "🤗" to "smiling_face_with_open_hands": "🤗"

Note: To do this I have written a python script that automates all the process. (If you want I can share it)

dcdunkan commented 1 year ago

Hi, thank you for the contribution.

While I appreciate your effort, it seems that the emoji count has went down from 3961 to 3664. And it should be 4115 with the addition of the new emoji. I investigated the issue a little bit and realised that the emoji list that you're using (the official one at unicode.org) does not list the skin tone variations, they're listed on a separate page. So, that needs to be fixed.

We've been getting the list of emoji from EmojiPedia using a script for scraping Apple emoji from there. And personally I think it is easier to fetch from EmojiPedia for now.

MaicolAntali commented 1 year ago

Ok thanks, I close this PR. 🤗

dcdunkan commented 1 year ago

Oh, you didn't have to close it :) I'd appreciate if you can take the job, use the mentioned script to update the list and be a contributor. It's okay if you can't. Thank you anyway.

MaicolAntali commented 1 year ago

Ohh yes I can handle it but I will create a new PR. Will be more clear.

dcdunkan commented 1 year ago

Awesome!