search

grammyjs / emoji

Helpers for sending emojis.
https://grammy.dev/plugins/emoji
MIT License
9 stars 2 forks source link

Added emoji file parsing #5

Closed andrrms closed 2 years ago

andrrms commented 2 years ago

Added a script to parse official emojis list from txt to JSON. This still needs one last fix in src/emojis.ts typing. I'll be grateful if someone can fix this.

Fix #3 Fix #4 References #2

andrrms commented 2 years ago

I fixed type errors. In order to do that, I needed to change emojis.json format, but changes was already reflected in another files. Upon review, if no errors are found, the plugin will be ready to enter its 1.0 version, thus being published in official documentation and in module repositories such as NPM and Deno Land.

KnorpelSenf commented 2 years ago

Are you aware of https://github.com/gurmanbh/emoji-scraper?

It may also make sense to simply extract the emoji that TDesktop ships. Those are already pre-formatted as JSON. Since we're building Telegram bots, all we need to support is what Telegram supports. Check out the file Telegram/lib_ui/emoji_suggestions/emoji_autocomplete.json in https://github.com/telegramdesktop/tdesktop. That's where I took the file from that I submitted in #2.

andrrms commented 2 years ago

At the end, the solution presented at #2 was the best. I didn't implemented it because I didn't knew where this file was obtained, but now I know and it gets easier to work with. Now with new changes implemented, I'll need again for approval.

As I said above, upon review, if no errors are found, the plugin will be ready to enter its 1.0 version, thus being published in official documentation and in module repositories such as NPM and Deno Land.

andrrms commented 2 years ago

A wild PR has appeared.

Jokes aside, I'll close this PR since a better one came out. See #6.