search

grammyjs / examples

Examples to kickstart your journey with grammY.
https://grammy.dev/demo/examples
MIT License
130 stars 33 forks source link

Reformat files #22

Closed rojvv closed 2 years ago

KnorpelSenf commented 2 years ago

This is a repo with examples for Node.js. Doesn't it make more sense to stick with Node tooling then?

rojvv commented 2 years ago

Does Node have a formatting "tooling"?

rojvv commented 2 years ago

It doesn't matter which tool we use, I want to keep them formatted for consistency because right now some places are using single quotes and the rest is using double quotes.

rojvv commented 2 years ago

I also believe that Prettier will have a similar result, too.

KnorpelSenf commented 2 years ago

Prettier is set up for this repo, it just needs to be applied correctly.

Loskir commented 2 years ago

some places are using single quotes and the rest is using double quotes.

and there’s kinda nothing wrong with it

rojvv commented 2 years ago

I'll use it to format everywhere except the Deno Deploy example, will this be okay?

Loskir commented 2 years ago

Supabase also uses deno tooling for example

rojvv commented 2 years ago

I'll exclude that, too.

Loskir commented 2 years ago

Oh no, not tab width 4

rojvv commented 2 years ago

Tab width will be decided by KnorpelSenf's formatting GmbH.

KnorpelSenf commented 2 years ago

Oh no, not tab width 4

I don't have too strong opinions about this

  1. Make a point why one is better than the other or vice versa
  2. Submit a PQ
  3. Party